-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/chaincmd dumpgenesis #39
Conversation
I have a hard time believing this doesn't already exist... although I could not find it anywhere.
Seems weird that MakeGenesis method doesn't return DefaultMainnet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (except one typo)
cmd/geth/chaincmd.go
Outdated
genesis = core.DefaultGenesisBlock() | ||
} | ||
if err := json.NewEncoder(os.Stdout).Encode(genesis); err != nil { | ||
utils.Fatalf("could not encode defaulty genesis") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils.Fatalf("could not encode defaulty genesis") | |
utils.Fatalf("could not encode default genesis") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made default into an adjective because there are more than one 'default' genes_es_ available... so 'could not encode default genesis' implies that it failed to encode the genesis, while in fact it failed with all/any of them...
EDIT
...so 'could not encode a default genesis' would be maybe a better way of saying this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jupp, @meowsbits, this was a unique feature for geth classic. I manually crafted the spec you linked above. I'm supporting this PR but would also encourage to move forward with actual chain specs just like parity or classic geth do. |
Made upstream, ethereum/go-ethereum#20191 |
I have a hard time believing this doesn't already exist... although I could not find it anywhere. @soc1c where/how do you make the configs like https://github.com/etclabscore/mordor/blob/master/mgeth.json ?
If it in fact this command (or an equivalent) doesn't already exist, then we should make this PR to ETH.
Use: