feat: XDai support #1136
Merged
feat: XDai support #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase 🙏 |
skellet0r
force-pushed
the
fix/xdai-support
branch
3 times, most recently
from
4bfb219
to
0e0d670
Compare
Limited support, only queries ABI from blockscout ATM. TODO: handle compilation errors
skellet0r
force-pushed
the
fix/xdai-support
branch
from
0e0d670
to
b385df4
Compare
iamdefinitelyahuman
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added Xdai to network config.
Enabled fetching ABI from blockscout api
Note: Although the blockscout api tries to be similar to etherscan, there are a few dis-similarities (mainly in naming conventions and return values)
Related issue: #934
How I did it
Handled the case when the explorer api is set to blockscout, easy to identify due to naming conventions and url
How to verify it
Drop into a brownie console and try fetching the source of a contract. here is one: 0x22Bd2A732b39dACe37AE7E8f50A186f3D9702e87
Checklist