Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass solc version to get_abi from compiler config file #1243

Merged
merged 1 commit into from
Sep 12, 2021
Merged

pass solc version to get_abi from compiler config file #1243

merged 1 commit into from
Sep 12, 2021

Conversation

gosuto-inzasheru
Copy link
Contributor

What I did

Related issue: #1242

How I did it

by adding a solc_version parameter to get_abi

How to verify it

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

not necessarily a draft, but would like some feedback before moving on to including a test case, updating the docs and/or adding an entry to the changelog.

if none of that is needed for a small fix such as this one, i guess it can directly be merged :)

@iamdefinitelyahuman iamdefinitelyahuman merged commit 6ac347a into eth-brownie:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants