Handle equal signs in network rpc address #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a network RPC address like `https://stardust.metis.io/?owner=588` fails with ``` Brownie v1.17.1 - Python development framework for Ethereum ('host=https://stardust.metis.io/\\?owner\\=588', 'chainid=588') File "brownie/_cli/__main__.py", line 64, in main importlib.import_module(f"brownie._cli.{cmd}").main() File "brownie/_cli/networks.py", line 68, in main fn(*args["<arguments>"]) File "brownie/_cli/networks.py", line 111, in _add args = _parse_args(args) File "brownie/_cli/networks.py", line 278, in _parse_args raise ValueError("Arguments must be given as key=value") from None ``` This fixed this.
iamdefinitelyahuman
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a network RPC address like
https://stardust.metis.io/?owner=588fails withThis fixed this.
What I did
Related issue: #
How I did it
How to verify it
Checklist