Ensure contract address exists in contract map before deleting #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1144
What I did
A simple check that the Key exists to avoid KeyError
Related issue: #1144
How I did it
How to verify it
Local and GitHub Action tests used to fail with KeyError in https://github.com/oceanprotocol/df-py/
Investigated against the existing issue in the brownie repo (#1144). Using
from_abidid not fix it when used as a combination (bothatandfrom_abi). Currently in df-py we are rewriting the problematic line from brownie/network/state.py using asedcommand:https://github.com/oceanprotocol/df-py/blob/ee7a5f9b1449ed3d308639add306d0c0f98a4a7e/.github/workflows/test.yml#L57
However, it seems like a no-hassle fix and would help a lot of devs using brownie.
Checklist