Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base #1703

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Add base #1703

merged 6 commits into from
Jan 29, 2024

Conversation

Tritium-VLK
Copy link
Contributor

@Tritium-VLK Tritium-VLK commented Jul 30, 2023

What I did

Just added a few lines to the regex to accept new env vars for BASE.

Also updated the starting network-config file to include mainnets and forks.
Related issue: #

How I did it

Just added a few lines that I am using locally.

How to verify it

I'm a forked version actively to operate on these chains and run cross-chain reporting.

I did not see any tests for side chain explorers, so I did not add one. I also could not find a fitting area to add more to the docs.

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

@Tritium-VLK
Copy link
Contributor Author

@charles-cooper here's base chain also. Then any chance for a new version number/tag so we can stop using a forked repo?

@iamdefinitelyahuman
Copy link
Member

Thanks for this. Need to find a way to future-proof this, some standard format of XXX_TOKEN so new chains don't endlessly require PRs (especially since the maintainer is asleep at the wheel lol)

@iamdefinitelyahuman iamdefinitelyahuman merged commit 45bd746 into eth-brownie:master Jan 29, 2024
6 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants