fix: KeyError when handling some RPC exceptions #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
- Coverage 88.19% 88.17% -0.03%
==========================================
Files 56 56
Lines 6304 6306 +2
Branches 1392 1393 +1
==========================================
Hits 5560 5560
- Misses 514 515 +1
- Partials 230 231 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Raise a
ValueErrorwhen the output used to create aVirtualMachineErrorcannot be properly parsed. This should fix issues withKeyErrorwhen Geth complains about e.g. a hardware wallet not being unlocked, or a lack of peers.