Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualMachineError fixes #555

Merged
merged 3 commits into from
May 26, 2020
Merged

VirtualMachineError fixes #555

merged 3 commits into from
May 26, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

  • Improve handling of VirtualMachineError in brownie.reverts
  • Raise ValueError when the returned RPC error does not contain a data field.

How to verify it

Run tests.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #555 into master will decrease coverage by 0.08%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
- Coverage   88.12%   88.03%   -0.09%     
==========================================
  Files          56       56              
  Lines        6309     6312       +3     
  Branches     1395     1396       +1     
==========================================
- Hits         5560     5557       -3     
- Misses        517      520       +3     
- Partials      232      235       +3     
Impacted Files Coverage Δ
brownie/test/managers/runner.py 85.57% <33.33%> (-0.84%) ⬇️
brownie/exceptions.py 84.31% <100.00%> (+0.15%) ⬆️
brownie/network/account.py 91.18% <0.00%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b6a27...c80cae2. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 44d07a0 into master May 26, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-exc-message branch May 26, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants