Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ganache shift bug & geth depth #562

Merged
merged 2 commits into from
May 28, 2020

Conversation

matnad
Copy link
Collaborator

@matnad matnad commented May 28, 2020

What I did

  1. Distinguish if we have a ganache or geth trace and save to tx._trace_origin
  2. Shift ganache gas costs by one step
  3. Reduce depth of geth traces by 1
  4. Added tx._call_cost = overhead cost to initiate the transaction

Related issue: #561

How I did it

see PR

How to verify it

tx.trace

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #562 into master will decrease coverage by 0.05%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   88.00%   87.94%   -0.06%     
==========================================
  Files          56       56              
  Lines        6319     6331      +12     
  Branches     1396     1399       +3     
==========================================
+ Hits         5561     5568       +7     
- Misses        523      527       +4     
- Partials      235      236       +1     
Impacted Files Coverage Δ
brownie/network/transaction.py 86.17% <58.33%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a888fc6...4e6cfb1. Read the comment docs.

@iamdefinitelyahuman
Copy link
Member

For the ganache portion, this is a (hopefully) temporary fix until trufflesuite/ganache#277 is resolved.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 27d7af1 into eth-brownie:master May 28, 2020
This was referenced Aug 5, 2020
@matnad matnad deleted the fix-expand-trace branch December 28, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants