fix: avoids development network to revert when atexit is being called
#660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to contribute back! the work done in this library is amazing 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When running a script using
developmentnetwork, even using aganacheinstance I launch, after finishing the execution the evm changes are reverted.How I did it
As pointed out by @iamdefinitelyahuman I removed the lines where invoked when exiting.
How to verify it
I haven't tried myself to automatically test the
atexithook, I can try to do so if required (I'm not a python dev so it might take me a while but a quick googling told me that hook is only executed then the process ends, in this case, pytest) . Manual test is required I'm afraid.Checklist