Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to choose console editing mode #970

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

dimitar-petrov
Copy link
Contributor

  • pass down prompt_toolkit EMACS or VI

What I did

Added a new option to console section to be able to choose editing mode.
Related issue: #

How I did it

Simple patch of Console class.

How to verify it

  1. Change editing_mode in default configuration file from emacs to vi
  2. Start brownie console and notice that vim keybindigs are available

Checklist

  • I have confirmed that my PR passes all linting checks
  • [-] I have included test cases
  • [-] I have updated the documentation
  • [-] I have added an entry to the changelog

@iamdefinitelyahuman
Copy link
Member

Can you please also update docs/config.rst to explain what this does and the available options?

@dimitar-petrov
Copy link
Contributor Author

Can you please also update docs/config.rst to explain what this does and the available options?

Updated docs/config.rst.

I did rebase and push though.
Would you mind telling me what is the best practice when adding more commits to a pull request and upstream have already diverged.

I see now the PR contains all commits not just mine.

@iamdefinitelyahuman
Copy link
Member

Yeah the commit history is a bit messy now. I'm not 100% on what your local setup looks like, this isn't the most efficient method but it's the most general approach I can think of that should fix :)

git reset --hard 3f554433
git cherry-pick 77b085c dfa8e6e c4d1a89
git push --force

@dimitar-petrov
Copy link
Contributor Author

Thanks, that took care of it.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 857a01f into eth-brownie:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants