Workarounds for broken complex type operator overloads in HIP 5.7 onwards #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
msimberg
force-pushed
the
hip-5.7-operator-workarounds
branch
from
73dd157 to
396f32e
Compare
|
cscs-ci run |
msimberg
force-pushed
the
hip-5.7-operator-workarounds
branch
from
396f32e to
a0011e0
Compare
|
cscs-ci run |
|
I've just discovered that it seems like spack patches the issue in HIP: https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/hip/0015-reverting-operator-mixup-fix-for-slate.patch. The upstream comment about use of the operators being discouraged still applies of course, and they haven't reverted the change that broke things upstream. That said I'm probably going to lower the priority of this a bit, and we can perhaps think longer term about a "whipblas" interface. |
|
I'll close this as #1195 proposes a simpler fix. We can always revisit the more complicated approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to see here yet. This is an ugly, hacky attempt at not using the broken upstream operators, but I'm unsure if 1. it works correctly, 2. it generates the same/similar code, and 3. if it's maintainable. Opening as PR to see how it works in CI. I know it compiles with HIP 5.2.3, nothing more.