-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Norm
communication asynchronous
#1221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
requested changes
Nov 27, 2024
it reduces a single value, not a tile
albestro
force-pushed
the
alby/norm-async-comm
branch
2 times, most recently
from
December 2, 2024 11:10
e9b3d3d
to
a50dcef
Compare
albestro
force-pushed
the
alby/norm-async-comm
branch
from
December 2, 2024 14:08
a50dcef
to
62c4814
Compare
rasolca
approved these changes
Dec 2, 2024
msimberg
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @albestro!
ETI question still open, but not a blocker for this PR (if ever).
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Norm is one of the few points left with synchronous communication. In particular, it uses an MPI_Reduce of a single value, which is a quite special use-case since all our helpers/wrappers/functions deal with tiles instead of simple values.
Instead of making the simple value appear as a Tile, which IMHO sounds a bit cumbersome, I opted for the opposite strategy which sounds more straightforward: implement an asynchronous reduction for the single value use-case.
Main changes:
It might be argued that: