Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI configuration with ROCm 6 #1240

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Dec 16, 2024

Adds a ROCm 6.0.2 CI configuration based on ubuntu 22.04 to test for issues like #1239.

@msimberg msimberg self-assigned this Dec 16, 2024
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

I've tested two new pipelines here, one with ROCm 6.0.2 (based on ubuntu 22.04) and another with 6.2.4 (based on ubuntu 24.04). In general I'd prefer the newer one, but the newer one has a build failure at the moment. For a potential 0.7.1 patch release my suggestion would be the following:

Are there other suggestions?

@albestro the 6.2.4 build fails on pika with https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/8655570178. This may also be an issue from clang 18 itself, completely independent of the ROCm version. However, does the failure look familiar?

ci/.gitlab-ci.yml Outdated Show resolved Hide resolved
ci/.gitlab-ci.yml Outdated Show resolved Hide resolved
ci/rocm/clang15_release_stdexec.yml Outdated Show resolved Hide resolved
ci/rocm/clang18_release_stdexec.yml Outdated Show resolved Hide resolved
@msimberg msimberg requested review from albestro, aurianer, rasolca and RMeli and removed request for albestro and aurianer December 17, 2024 08:42
@rasolca
Copy link
Collaborator

rasolca commented Dec 17, 2024

I've tested two new pipelines here, one with ROCm 6.0.2 (based on ubuntu 22.04) and another with 6.2.4 (based on ubuntu 24.04). In general I'd prefer the newer one, but the newer one has a build failure at the moment. For a potential 0.7.1 patch release my suggestion would be the following:

* keep the 6.0.2 pipeline in this PR for 0.7.1

* add a fix like [Add workaround for ambiguous complex multiplication overloads in HIP in `larft.cu` #1241](https://github.com/eth-cscs/DLA-Future/pull/1241) for 0.7.1

* once 0.7.1 is released, revisit issues with the 6.2.4 pipeline

Are there other suggestions?

Looks like a good plan.

@msimberg
Copy link
Collaborator Author

cscs-ci run

@rasolca
Copy link
Collaborator

rasolca commented Dec 17, 2024

Expected to fail tests. Will be fixed in #1241.

@rasolca rasolca merged commit 76dc68d into eth-cscs:master Dec 17, 2024
4 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@msimberg msimberg deleted the rocm-6-ci branch December 17, 2024 18:03
msimberg added a commit that referenced this pull request Dec 18, 2024
@msimberg msimberg added this to the v0.7.1 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants