Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C and ScaLAPACK-like API for generalised eigensolver #992

Merged
merged 12 commits into from
Sep 28, 2023
Merged

C and ScaLAPACK-like API for generalised eigensolver #992

merged 12 commits into from
Sep 28, 2023

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Sep 25, 2023

Close #947.

@RMeli RMeli added Type:New Feature New feature or request Priority:Low labels Sep 25, 2023
@RMeli RMeli self-assigned this Sep 25, 2023
RMeli
RMeli commented Sep 25, 2023
View reviewed changes
Copy link
Member Author

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting.

test/unit/eigensolver/test_gen_eigensolver.cpp Outdated Show resolved Hide resolved
test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp Outdated Show resolved Hide resolved
@RMeli
Copy link
Member Author

RMeli commented Sep 25, 2023

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Sep 25, 2023

cscs-ci run

RMeli
RMeli commented Sep 25, 2023
View reviewed changes
test/unit/eigensolver/test_gen_eigensolver.cpp
Comment on lines -69 to -72
template <class T, Device D, class... GridIfDistributed>
void testGenEigensolverCorrectness(const blas::Uplo uplo, Matrix<const T, Device::CPU>& reference_a,
Matrix<const T, Device::CPU>& reference_b,
EigensolverResult<T, D>& ret, GridIfDistributed... grid) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to include/dlaf_test/test_gen_eigensolver_correctness.h.

@RMeli RMeli marked this pull request as ready for review September 26, 2023 06:36
msimberg
msimberg approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp Outdated Show resolved Hide resolved
@msimberg msimberg added Type:Bug Something isn't working TODO:Task and removed Type:New Feature New feature or request Priority:Medium labels Sep 27, 2023
@msimberg msimberg added Category:CI not planned Feature currently outside of the roadmap that might be considered in the future Priority:Low labels Sep 27, 2023
@rasolca rasolca added Priority:High Type:New Feature New feature or request and removed Priority:Low Type:Bug Something isn't working TODO:Task Category:CI not planned Feature currently outside of the roadmap that might be considered in the future labels Sep 27, 2023
@RMeli
Copy link
Member Author

RMeli commented Sep 28, 2023

cscs-ci run

1 similar comment
@RMeli
Copy link
Member Author

RMeli commented Sep 28, 2023

cscs-ci run

@rasolca rasolca merged commit b0a5525 into eth-cscs:master Sep 28, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@rasolca
Doc C and ScaLAPACK-like API for generalised eigensolver (#992)
9bc4e78
@RMeli RMeli deleted the c-api-gen-eig branch September 28, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasolca rasolca rasolca approved these changes

@msimberg msimberg msimberg approved these changes

@albestro albestro Awaiting requested review from albestro

@aurianer aurianer Awaiting requested review from aurianer

Assignees

@RMeli RMeli

Labels
Priority:High Type:New Feature New feature or request
Projects
DLA-F Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add C/ScaLAPACK API for generalized eigensolver
3 participants
@RMeli @msimberg @rasolca