Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node info endpoint #101

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Add node info endpoint #101

merged 7 commits into from
Apr 24, 2024

Conversation

rsarm
Copy link
Collaborator

@rsarm rsarm commented Apr 17, 2024

No description provided.

@rsarm rsarm requested a review from ekouts April 17, 2024 16:20
@rsarm rsarm self-assigned this Apr 17, 2024
Copy link
Collaborator

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it works fine with the demo env, but I have some small suggestions.

firecrest/AsyncClient.py Outdated Show resolved Hide resolved
firecrest/AsyncClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
tests/test_compute_async.py Outdated Show resolved Hide resolved
tests/test_compute_async.py Outdated Show resolved Hide resolved
tests/test_compute_async.py Outdated Show resolved Hide resolved
firecrest/AsyncClient.py Show resolved Hide resolved
firecrest/BasicClient.py Show resolved Hide resolved
@rsarm rsarm requested a review from ekouts April 23, 2024 12:10
tests/test_compute_async.py Outdated Show resolved Hide resolved
tests/test_compute_async.py Outdated Show resolved Hide resolved
@ekouts ekouts merged commit d2a1e0f into eth-cscs:main Apr 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants