Update path.py::mkdir
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firecrest does not support `exist_ok`, it's somehow blended into `parents`
|
Hi @ekouts |
ekouts
approved these changes
Oct 21, 2024
|
Hi @khsrali , in this repo we usually use the "assignee" as the responsible for fixing possible review comments/syncing with main etc. 😅 No need for this one, I merged ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FirecREST does not support
exist_ok, it's somehow blended intoparents.This PR, checks if
exist_ok=True, in that case setsp=True, regardless.P.S. We still have issue eth-cscs/firecrest#202 open.
If
exist_ok=Falseandparent=False, and file actually exists, it still might return a wrong error type:X-Invalid-Pathinstead ofX-Exists, but that's another issue.