Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First input of urllib.request.urlopen could only be of type 'str' or a Request object. #89

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Feb 29, 2024

Right now, url in AsyncExternalDownload is of type dictionary, which leads to the following error:

AttributeError: 'dict' object has no attribute 'timeout'
See: https://docs.python.org/3/library/urllib.request.html#module-urllib.request

…a Request object.

Right now, `url` in AsyncExternalDownload is of type dictionary that leads to following error:

AttributeError: 'dict' object has no attribute 'timeout'
See: https://docs.python.org/3/library/urllib.request.html#module-urllib.request
Copy link
Collaborator

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks! To my knowledge there isn't anyone external using the async client of pyfirecrest, so it would be good to have some feedback! Please report anything weird or not properly documented, if you use it! :)

@ekouts ekouts merged commit afdfdb6 into eth-cscs:main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants