Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide methods for closing and create the httpx session in AsyncFirecrest #97

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Apr 3, 2024

One of the issues mentioned in #94 .

The code that was failing could look like that:

...
async def get_systems():
    await _client.create_new_session()
    systems = await _client.all_services()
    await _client.close_session()

asyncio.run(get_systems())
asyncio.run(get_systems())

@ekouts ekouts requested a review from rsarm April 3, 2024 16:33
@ekouts ekouts self-assigned this Apr 3, 2024
@ekouts ekouts merged commit 2f47bd4 into eth-cscs:main Apr 4, 2024
8 checks passed
@ekouts ekouts deleted the close_httpx_session branch April 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants