-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tensorboard Support #292
Merged
robin-oester
merged 7 commits into
main
from
robin-oester/feature/#281-provide_evaluation_visualization
Aug 19, 2023
Merged
Add Tensorboard Support #292
robin-oester
merged 7 commits into
main
from
robin-oester/feature/#281-provide_evaluation_visualization
Aug 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* startup via subprocess.call * add evaluation result writer to support different evaluation result formats
This comment was marked as outdated.
This comment was marked as outdated.
robin-oester
commented
Jul 17, 2023
MaxiBoether
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I had some comments but overall looks good :)
* separate evaluation result writers * mitigate excessive logging of tensorboard * add unit tests
This reverts commit 9a5da0d.
MaxiBoether
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for getting back so late :) LGTM
XianzheMa
deleted the
robin-oester/feature/#281-provide_evaluation_visualization
branch
July 3, 2024 21:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement basic functionality to provide the user with evaluation metrics visualization as described in #281. Tensorboard should run on the supervisor and visualize evaluation metrics over time.