Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tensorboard Support #292

Merged

Conversation

robin-oester
Copy link
Collaborator

Implement basic functionality to provide the user with evaluation metrics visualization as described in #281. Tensorboard should run on the supervisor and visualize evaluation metrics over time.

* startup via subprocess.call
* add evaluation result writer to support different evaluation result formats
@github-actions

This comment was marked as outdated.

@robin-oester robin-oester linked an issue Jul 17, 2023 that may be closed by this pull request
@robin-oester robin-oester self-assigned this Jul 17, 2023
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I had some comments but overall looks good :)

modyn/config/schema/modyn_config_schema.yaml Show resolved Hide resolved
modyn/supervisor/supervisor.py Show resolved Hide resolved
modyn/supervisor/supervisor.py Outdated Show resolved Hide resolved
modyn/supervisor/supervisor.py Outdated Show resolved Hide resolved
modyn/supervisor/supervisor.py Outdated Show resolved Hide resolved
* separate evaluation result writers
* mitigate excessive logging of tensorboard
* add unit tests
* change result_writers to be required
This reverts commit 9a5da0d.
* change result_writers to be required
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for getting back so late :) LGTM

@robin-oester robin-oester merged commit 013e7af into main Aug 19, 2023
8 checks passed
@XianzheMa XianzheMa deleted the robin-oester/feature/#281-provide_evaluation_visualization branch July 3, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Visualization for Evaluation Metrics
2 participants