chore (p2p): Published a list of canonical mempools file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `StrictNoSign` signature policy to be consistent with the ETH2 spec.
ch4r10t33r
changed the title
ch4r10t33r
changed the title
|
Are these files pinned somewhere? The gateway links don't currently work. We should also have a copy of each such file in the repo so anyone can pin them. |
Yes, they were. I'll check why the pinned links do not work anymore. |
drortirosh
reviewed
Jan 21, 2024
|
Can you add a link here? https://github.com/eth-infinitism/bundler-spec/blob/main/p2p-specs/p2p-interface.md#canonical-mempools (the PR with this previous request already merged) |
dancoombs
approved these changes
Jan 22, 2024
drortirosh
reviewed
Feb 18, 2024
| | `Goerli` | 5 | `QmTmj4cizhWpEFCCqk5dP67yws7R2PPgCtb2bd2RgVPCbF` | https://ipfs.io/ipfs/QmTmj4cizhWpEFCCqk5dP67yws7R2PPgCtb2bd2RgVPCbF?filename=goerli_canonical_mempool.yaml | ||
| | `Sepolia` | 11155111 | `QmdDwVFoEEcgv5qnaTB8ncnXGMnqrhnA5nYpRr4ouWe4AT` | https://ipfs.io/ipfs/QmdDwVFoEEcgv5qnaTB8ncnXGMnqrhnA5nYpRr4ouWe4AT?filename=sepolia_canonical_mempool.yaml | ||
| | `Mumbai` | 80001 | `QmQfRyE9iVTBqZ17hPSP4tuMzaez83Y5wD874ymyRtj9VE` | https://ipfs.io/ipfs/QmQfRyE9iVTBqZ17hPSP4tuMzaez83Y5wD874ymyRtj9VE?filename=mumbai_canonical_mempool.yaml | ||
|
|
There was a problem hiding this comment.
- we should reference the source documents (in this repo) of the mempools (its in another pr)
- should have a clear definition of what the ID is. (that is, how to take a clear-text, and calculate the CID of it)
should copy/reference a definition - but I couldn't find it in the IPFS spec.
I think it is something like"Qm"+ base58(keccak256(text)), but not exactly. even "kubo" tool is inconsistent, in thatkubo < filegives different ID fromkubo file...
Added the mempool yamls files for Polygon mainnet
Added the yaml file for Arbitrum sepolia canonical mempool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Published a list of canonical mempools file