Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP Editing Office Hour Meeting 26 #277

Closed
5 of 26 tasks
poojaranjan opened this issue Sep 19, 2023 · 24 comments
Closed
5 of 26 tasks

EIP Editing Office Hour Meeting 26 #277

poojaranjan opened this issue Sep 19, 2023 · 24 comments

Comments

@poojaranjan
Copy link
Member

poojaranjan commented Sep 19, 2023

Date & Time

Tuesday, October 31, 2023, at 15:00 UTC

Location

Zoom: TBA on EthCatHerders Discord #eip-editors
Recording: https://www.youtube.com/playlist?list=PL4cwHXAawZxqnDHxOyuwMpyt5s8F8gdmO

Agenda

  • Visit EIPs
  • Rename it to ERC Editing Office Hour?
  • Next meeting time?

To Final

To Last Call

To Review

To Withdrawan

TBA

Misc PR

To Draft

Requested in comments

Added from the past meetings
TBA

From Satgnant

TBA

Old links

Open Q&A

Other details

(Add your Pull Request number to be added to the agenda.)

@OniReimu
Copy link

Hi @poojaranjan , could you please include ethereum/EIPs#7632, thanks.

@poojaranjan poojaranjan mentioned this issue Sep 20, 2023
7 tasks
@HelloRickey
Copy link

Hi @poojaranjan please take a look at
ethereum/EIPs#7651
thanks

@d4mr
Copy link

d4mr commented Sep 26, 2023

Hi @poojaranjan can ethereum/EIPs#7719 be included as well please,
thanks

@bafu
Copy link

bafu commented Oct 3, 2023

Hi Pooja, I would like to discuss ethereum/EIPs#7682 (EIP-7517) and move it to Draft. Thank you!

@bafu
Copy link

bafu commented Oct 3, 2023

Hi Pooja, I would like to discuss ethereum/EIPs#7804 (EIP-7053) and move it to Final. Thank you!

@poojaranjan
Copy link
Member Author

In the absence of the EIP editor, we're skipping this week. Hopefully, PRs will be merged async in the meantime. If not, it will be reviewed at the next meeting.

This was referenced Oct 4, 2023
@Edoumou
Copy link

Edoumou commented Oct 9, 2023

Hi Pooja, I would like to discuss ethereum/EIPs#7667 (ERC-7092) and move it to Review. Thank you.

@kopy-kat
Copy link

Hi Pooja, I would like to discuss ethereum/EIPs#7484 and merge the first draft. Thank you!

@strumswell
Copy link

Review of ethereum/EIPs#7547 would be appreciated.

@poojaranjan
Copy link
Member Author

In the absence of the EIP editor, we're skipping this week. Hopefully, PRs will be merged async in the meantime. If not, it will be reviewed at the next meeting on October 31, 2023.

@poojaranjan poojaranjan mentioned this issue Oct 18, 2023
15 tasks
@ryanio
Copy link

ryanio commented Oct 19, 2023

Hi Pooja 👋 I would like to discuss adding these EIPs (sync or async is fine!):
Add EIP: NFT Dynamic Traits #7500
Add EIP: NFT Redeemables #7501 (uses Dynamic Traits)

Have had an initial review/approval from @g11tech but need ✅ from @SamWilsn since he is still in "Requested Changes" state for the EIP numbers update (which has been done).

@poojaranjan
Copy link
Member Author

@ryanio
I have added it to the agenda. However, I see the requested changes by two different reviewers. I recommend reaching both of them on EthCatHerders Discord #eip-editors channel.

@tbergmueller
Copy link

Hi @poojaranjan ,

we'd like to move ERC-6956 to review and discuss any open poins in the upcoming meeting, in case not approved before.
ethereum/EIPs#7903

Side-note, small typo in your ticket description, From Satgnant ;)

@dhl
Copy link

dhl commented Oct 24, 2023

Hi @poojaranjan,

My team have requested for ERC-6596 to be
moved to review state, and would like to bring this up for discussion during the office hour if the changes have not been merged by then. Would you mind including this on the agenda please?

@Edoumou
Copy link

Edoumou commented Oct 26, 2023

Hello @poojaranjan,

I was wondering if one should reference the new PR after moving ERCs to a separated directory.
If so, then I would like to discuss ethereum/ERCs#19 (ERC-7092) and move it to Review. Thank you.

@strumswell
Copy link

Same for me ethereum/ERCs#21

@tbergmueller
Copy link

tbergmueller commented Oct 27, 2023

Same for me;
Instead of ethereum/EIPs#7903
please use
ethereum/ERCs#43

Note that for all PRs at the moment pipelines in the ERCs repo fail, mostly due to spelling mistakes and broken links in other ERCs. These are known issues and being actively worked on I believe

@Joeysantoro
Copy link

Can we add: ethereum/ERCs#78 to move ERC-7535 to Review and ethereum/ERCs#57 to fix a typo on final ERC-2612?

@poojaranjan
Copy link
Member Author

@Joeysantoro ethereum/ERCs#78 has been added to this meeting. However ERC-2612 is in Final status, it is added to the EIPIP meeting.

@bafu
Copy link

bafu commented Oct 31, 2023

Hi Pooja, I would like to discuss ethereum/EIPs#7682 (EIP-7517) and move it to Draft. Thank you!

@dhl
Copy link

dhl commented Oct 31, 2023

Hi @poojaranjan! The invite link to discord doesn't work. Would you mind sharing the link?

@poojaranjan
Copy link
Member Author

@dhl ECH Discord

@poojaranjan
Copy link
Member Author

Pull requests that couldn't be discussed today are added to the next meeting. But we hope for them to be merged before the next EIP Editing Office Hour.

@poojaranjan
Copy link
Member Author

Closed in favor of #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests