Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP Editing Office Hour Meeting 27 #290

Closed
12 of 19 tasks
poojaranjan opened this issue Oct 31, 2023 · 4 comments
Closed
12 of 19 tasks

EIP Editing Office Hour Meeting 27 #290

poojaranjan opened this issue Oct 31, 2023 · 4 comments

Comments

@poojaranjan
Copy link
Member

poojaranjan commented Oct 31, 2023

Date & Time

Tuesday, Nov 14, 2023, at 15:00 UTC

Location

Zoom: TBA on EthCatHerders Discord #eip-editors
Recording: https://www.youtube.com/playlist?list=PL4cwHXAawZxqnDHxOyuwMpyt5s8F8gdmO

Agenda

  • Visit EIPs
  • Rename it to ERC Editing Office Hour?

To Final

To Last Call

To Review

To Withdrawan

TBA

Misc PR

To Draft

Requested in comments

Added from the past meetings
TBA

From Satgnant

TBA

Open Q&A

Other details

(Add your Pull Request number to be added to the agenda.)

@saitama2009
Copy link

Hi @poojaranjan can ethereum/ERCs#77 be included please
thanks

@tbergmueller
Copy link

Hi @poojaranjan,

thanks for carrying over ethereum/ERCs#43 from the last meeting, where we didn't get to it.
Unfortunately I cannot attend today as I'm at a conference, would be great if @SamWilsn could address my question, I'd watch the recording later;

  • HTML-Proofer fails with the links (Link to run: https://github.com/ethereum/ERCs/actions/runs/6861154707/job/18656264411?pr=43). Note the error-messages still have EIPs in path, e.g. * At ./_site/EIPS/eip-6956.html:238: internal image ../assets/erc-6956/img/erc6956_concept.svg does not exist
  • Rebased the branch on master just today
  • I adopted to the new file structure, e.g. renaming links to erc-xxxx.md, ../assets/erc-6956/*, ...
  • Markdown including all links, images, assets works for me locally.
  • Is this an HTMLProofer-Issue, or do I need to take further action?

@SamWilsn
Copy link
Collaborator

@tbergmueller as far as I am aware (and @Pandapip1 or @lightclient can correct me), you should still be using ./eip-NNNN.md for links to other proposals, and ../assets/eip-NNNN/... for links to your assets. HTMLProofer can't really be trusted right now.

@poojaranjan
Copy link
Member Author

Closing in favor of #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants