Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misuse of in instead of includes method for checking array #6755

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Suyun114
Copy link
Contributor

fixes #6726

@SamTV12345
Copy link
Member

You're absolutely right. This is like an ancient bug in Etherpad. It already existed here:

if(!(lang in that.loader.langs)) {// uh, we don't have this lang availbable..
. I'll test it and check if this fixes the issue.

@SamTV12345 SamTV12345 merged commit 8c1a519 into ether:develop Nov 15, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

locale broken after update
2 participants