fixing set function bug for deprecated use
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamTV12345
approved these changes
Oct 6, 2023
|
@robertschnuell Thanks for the fix. It indeed is an error. In earlier js files the call was correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in the process of refactoring from .js to .ts a bug got created which breaks the deprecated usage of the
setfunction. This PR is fixing this problem.Its just three letters which got wrong.
cbDb.get.callwhich needed to becbDb.set.call: https://github.com/ether/ueberDB/blob/main/index.ts#L223This creates a misfunction way ahead in some third party etherpad plugin usage (in this case framasoft/ep_mypads ) with the current release of etherpad (1.9.3).
While etherpad 1.9.1 still uses ueberDB2 (v4.0.11) it works still fine. This was before the refactoring to typescript and in this case the
setfunction was still usingcbDb.set.callas it can be seen here:ueberDB/index.js
Line 132 in 6919908
would be great if this PR got merged as well as etherpad dependency to ueberDB2 could be updated in the coming etherpad release, so that it is possible to run framasoft/ep_mypads on the latest etherpad relase again.