Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eip155-2023.json #5935

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

BharatBlockChain
Copy link

No description provided.

Copy link

github-actions bot commented Oct 4, 2024

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other chain seems inoperative currently - but I would like to wait a bit to see if it is not just temporary

@BharatBlockChain
Copy link
Author

the other chain seems inoperative currently - but I would like to wait a bit to see if it is not just temporary

Thanks for letting me know. May i know the next step ?

@BharatBlockChain
Copy link
Author

Please review the updates

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok the other chain seems to be really down - but you need to add redflags reusedchainid

@BharatBlockChain
Copy link
Author

Dear Team, Please review the RPC

Copy link
Author

@BharatBlockChain BharatBlockChain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated
"redflags": {
"reusedchainid": true
},

@BharatBlockChain
Copy link
Author

Dear Team, Please Review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants