-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Display info when --tstop/--tstart temperatures are reached. #1159
Display info when --tstop/--tstart temperatures are reached. #1159
Conversation
9595ef7
to
3aeb66d
Compare
3aeb66d
to
6198328
Compare
Sorry for my poor understanding but ... why keep cnote commented out ? |
I don't wanted to make any performance impacts depending on my (already commented) "debugging" infos - due the #1146 was accepted and merged. |
This is my personal opinion. CLI args --tstop and --tstart are user activated thus the user expects to see some behavior happen when temp threshold kicks in. |
@StefanOberhumer I'm am also of the view that, at a minimum, a cnote log entry should accompany any GPU tstop/tstart state transition. I would even suggest a cwarn on stopping a GPU. I'm also a little puzzled with this feature... my NV GPUs do a pretty good job of automatically adjusting fans and throttling work to manage temp. |
Adapted (cwarn if --tstop is reached, cinfo if --tstart is reached) (Think I cannot rename the branch when a PR is open without closing the PR .... so I left the name of my branch unchanged ... ) |
But: How does your cards
? |
Ah, ok. 60C is very low. I've seen cards that run comfortably at 80C... In Nvidia 10x0 series GPUs, temp and power limits are handled by the GPU's hardware dispatch. The dispatcher will automatically back off the number of running work groups. Not sure were the temp. limit is but it's above 80C. I believe the silicon is spec'd at up to 100C!!! |
Well I 've seen some setting using I image that I saw info about throtteling about 90°.
Let's see what summer brings - maybe I have to update my target temperature ;-) Thanks for your info & feedback |
@StefanOberhumer One more thing... I missed it too but there's a new practice of updating the CHANGELOG.md file with functional changes such as this one. I think the intent is to include this changelog update with the PR. This PR is already merged, so perhaps you could submit a further PR to update the changelog? |
@chfast Should the CHANGELOG update be included with the functional PR, or should it be submitted as a separate PR? Including the CHANGELOG update with the code update PR would be clean, but also cause a lot of forced branch merges... |
It's better to include it with the PR. But I don't mind updating it later on. |
No description provided.