Clean up command line arguments processing

[jean-m-cyr]

No description provided.

[AndreaLanfranchi]

Is it me missing something or we do loose some sanity checks over entered values ?
For example that --tstop must be ge than --tstart ...

[jean-m-cyr]

@AndreaLanfranchi The check can only occur after the parse, but it is included below.

ethminer/ethminer/MinerAux.h

Line 509 in 92604d5

if (m_tstop && (m_tstop <= m_tstart))

[AndreaLanfranchi]

Sorry ... I was totally missing that.

[jean-m-cyr]

This builds on @chfast's work creating the CLI11 hunter package, making it available for us to use.

There is very little left in main.cpp! Should I combine main.cpp and Mineraux.h into a single file. There are no other includes of Mineraux.

[AndreaLanfranchi]

Good idea.
Worth it to have 2 files with single name: a proper header and a proper code file. (one .h and one .cpp)
IMHO

[jean-m-cyr]

I was thinking a single main.cpp file. MinerAux.h is only included by main.cpp so it is not the typical header file. It contains mostly executable code and no common (shared) variables. It is strictly for main.cpp's use, so why not just include it as part of main.cpp instead of #including it as a separate file?

[AndreaLanfranchi]

Mine was only a suggestion due to personal habit ... wether there is a class (MinerCLI is) I prefer to have definition into .h and executable code in .cpp
But it's only cosmetic and I reckon It might involve some additional lines to write definitions.

[jean-m-cyr]

There is no consistency in that respect in Ethminer. Some seem to prefer .h only formulation with executable code inline, others as you say with separate header and executable components. I'll adapt to whatever style is currently in use.

[chfast]

There is very little left in main.cpp! Should I combine main.cpp and Mineraux.h into a single file. There are no other includes of Mineraux.

Definitely, move code from MinerAux to main.cpp. The MinerAux was shared between eth/main and ethminer/main long time ago.

[AndreaLanfranchi]

@jean-m-cyr could you please add in help text the meanings for stratumx+tcp modes ?
Since we've dropped -SP argument we have also dropped the description and now people do not understand whether to use stratum / stratum1 / stratum2

stratum: official stratum spec: ethpool, ethermine, coinotron, mph, nanopool (default)
stratum1: eth-proxy compatible: dwarfpool, f2pool, nanopool (required for hashrate reporting to work with nanopool)
stratum2: EthereumStratum/1.0.0: nicehash

[AndreaLanfranchi]

Good for me