This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
Critical amendment to GetWorkClient #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaLanfranchi
changed the title
chfast
suggested changes
Jun 4, 2018
| @@ -13,7 +13,7 @@ using namespace eth; | |||
| class EthGetworkClient : public PoolClient, Worker | |||
| { | |||
| public: | |||
| EthGetworkClient(unsigned const & farmRecheckPeriod); | |||
| EthGetworkClient(unsigned const & farmRecheckPeriod, bool const & submitHashrate); | |||
There was a problem hiding this comment.
This is wrong. Pass both arguments by value.
| // Store the solution in temp var. Will be handled in workLoop | ||
| m_solutionToSubmit = solution; | ||
| // Immediately send found solution without wait for loop | ||
| if (m_connected || m_justConnected) { |
There was a problem hiding this comment.
What is the m_justConnected flag for?
There was a problem hiding this comment.
Really do not know. I only replicated what i believe is the "connected" condition imposed in workloop. I did not write this class.
| // Store the solution in temp var. Will be handled in workLoop | ||
| m_solutionToSubmit = solution; | ||
| // Immediately send found solution without wait for loop | ||
| if (m_connected || m_justConnected) { |
There was a problem hiding this comment.
What is the m_justConnected flag for?
There was a problem hiding this comment.
Really do not know. I only replicated what i believe is the "connected" condition imposed in workloop. I did not write this class.
|
Also add CHANGELOG entry. |
Addresses #1213 - Solution submit is immediate upon arrival and is no influenced by --farm-recheck value - Submission of hashrate is conditional - Renamed m_report_stratum_hashrate to m_report_hashrate as it's valid for both modes Now even sligtly higher --farm-recheck values may be applied to mitigate overhead.
chfast
approved these changes
Jun 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1213
Now even sligtly higher --farm-recheck values may be applied to mitigate overhead.