Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilise Eddsa & Public Keys - Part 1 #791

Closed
wants to merge 19 commits into from
Closed

Utilise Eddsa & Public Keys - Part 1 #791

wants to merge 19 commits into from

Conversation

biscuitdey
Copy link
Collaborator

Description

Use Eddsa signatures in createBpiSubject and updateBpiSubject

Related Issue

#759

Motivation and Context

Use multiple types of signatures

How Has This Been Tested

Running all existing tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

Therecanbeonlyone1969
Therecanbeonlyone1969 previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ognjenkurtic
Copy link
Collaborator

Please also run and fix prettier and linter

@biscuitdey
Copy link
Collaborator Author

Code added to #794

1 similar comment
@biscuitdey
Copy link
Collaborator Author

Code added to #794

@biscuitdey biscuitdey closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ognjenkurtic ognjenkurtic ognjenkurtic left review comments

@Therecanbeonlyone1969 Therecanbeonlyone1969 Therecanbeonlyone1969 left review comments

@skarred14 skarred14 Awaiting requested review from skarred14 skarred14 is a code owner

@Kasshern Kasshern Awaiting requested review from Kasshern Kasshern is a code owner

@Ybittan Ybittan Awaiting requested review from Ybittan Ybittan is a code owner

@skosito skosito Awaiting requested review from skosito skosito is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@biscuitdey @CLAassistant @ognjenkurtic @Therecanbeonlyone1969