Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken dependencies #802

Merged
merged 4 commits into from
Jun 30, 2024
Merged

Fix broken dependencies #802

merged 4 commits into from
Jun 30, 2024

Conversation

biscuitdey
Copy link
Collaborator

Description

This PR fixes the peer dependency between etherjs v6 and hardhat-etherjs.

Related Issue

#799

How Has This Been Tested

Ran all existing tests locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

@biscuitdey biscuitdey linked an issue Jun 30, 2024 that may be closed by this pull request
npm i broken in bri-3 project #799
Closed
@biscuitdey biscuitdey changed the base branch from main to develop June 30, 2024 07:57
@ognjenkurtic ognjenkurtic merged commit 31da6f3 into develop Jun 30, 2024
2 checks passed
@ognjenkurtic ognjenkurtic deleted the 799-npm-i-broken-in-bri-3-project branch June 30, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ognjenkurtic ognjenkurtic ognjenkurtic approved these changes

@skarred14 skarred14 Awaiting requested review from skarred14

@Therecanbeonlyone1969 Therecanbeonlyone1969 Awaiting requested review from Therecanbeonlyone1969

@Kasshern Kasshern Awaiting requested review from Kasshern

@Ybittan Ybittan Awaiting requested review from Ybittan

@skosito skosito Awaiting requested review from skosito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm i broken in bri-3 project
2 participants
@biscuitdey @ognjenkurtic