Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRI - 811 Add workflowId and workstepId to transaction #820

Conversation

biscuitdey
Copy link
Collaborator

Description

This PR adds workflowId and workstepId to transaction.
This values are generated once a transaction execution is started.

Related Issue

#811

Motivation and Context

Previously, the values being stored was the workflowId and workstepId in the workflowInstanceId and workstepInstanceId

How Has This Been Tested

All previous tests are running.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@biscuitdey biscuitdey merged commit 9dfeedc into develop Jul 22, 2024
2 checks passed
@biscuitdey biscuitdey deleted the 811-sri-add-workflowid-and-workstepid-to-transaction-model-and-generate-instance-ids-on-each-execution branch July 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SRI - Add workflowId and workstepId to transaction model and generate instance ids on each execution
2 participants