Skip genesis state check for transitioned networks #245
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trianglesphere
force-pushed
the
jg/snap_sync_init_bug
branch
from
e6b59d3
to
f41dd8c
Compare
trianglesphere
changed the title
trianglesphere
force-pushed
the
jg/snap_sync_init_bug
branch
from
f41dd8c
to
f712598
Compare
sebastianst
reviewed
Feb 16, 2024
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On restarts, nodes that had completed snap sync without using a datadir on transitioned networks would re-commit the genesis state. This would set the local block back to the genesis block and wipe away the state after snap sync. Because op-geth is not able to execute the STF pre-bedrock, it is ok to skip storing this data.
Tests
Tested on op-goerli.