Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: attempt op-geth 1.13.12 #10205

Closed
wants to merge 2 commits into from
Closed

Conversation

axelKingsley
Copy link
Contributor

@axelKingsley axelKingsley commented Apr 18, 2024

This PR demonstrates that the monorepo works without modification against geth version v1.13.12

Because it does nothing besides update go.mod, it likely does not need to be merged. Instead, later version upgrades require real changes and do need to be merged.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (4a3d3fb) to head (5406bdb).
Report is 214 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10205       +/-   ##
============================================
+ Coverage    42.40%   82.29%   +39.89%     
============================================
  Files           73       10       -63     
  Lines         4830     1073     -3757     
  Branches       766        0      -766     
============================================
- Hits          2048      883     -1165     
+ Misses        2676      159     -2517     
+ Partials       106       31       -75     
Flag Coverage Δ
cannon-go-tests 82.29% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

@axelKingsley axelKingsley force-pushed the axel/geth_1_13_12 branch 3 times, most recently from 01b5c2e to 692d73f Compare April 18, 2024 15:10
Copy link
Contributor

semgrep-app bot commented Apr 23, 2024

Semgrep found 13 sol-style-notice-over-dev-natspec findings:

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 1 dangerous-exec-command finding:

  • op-challenger/game/fault/trace/cannon/executor.go

Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code.

Ignore this finding from dangerous-exec-command.

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@protolambda
Copy link
Contributor

Geth dep is at v1.13.15 / v1.101315.1-rc.2 already, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants