Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: op-node interop block verification (devnet-1 scope) #11611

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Aug 27, 2024

Description

Op-node changes needed to interface with the new op-supervisor service for cross-L2 safety checks of L2 blocks.

TODO:

  • add invalid safety status (or something akin to that) to supervisor types/API, to identify blocks with invalid executing messages.

Tests

  • unit testing of new interop deriver
  • action testing of safety increments

Metadata

Fix #11312

Also fix #10886

@axelKingsley
Copy link
Contributor

add invalid safety status (or something akin to that) to supervisor types/API, to identify blocks with invalid executing messages.

I cut a new PR on top of my API to address this.

#11613

@protolambda
Copy link
Contributor Author

Opened #11672 to track the finalizer changes to make in op-node, in devnet 2 scope.

@protolambda protolambda changed the title op-node: experimental interop block verification op-node: op-node interop block verification (devnet-1 scope) Aug 29, 2024
@protolambda protolambda marked this pull request as ready for review August 30, 2024 15:55
@protolambda protolambda requested review from a team and ajsutton as code owners August 30, 2024 15:55
@protolambda protolambda added this to the Interop: Devnet 1 milestone Aug 30, 2024
@protolambda protolambda self-assigned this Aug 30, 2024
Copy link
Contributor

@axelKingsley axelKingsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking comments

op-e2e/actions/l2_verifier.go Show resolved Hide resolved
op-node/flags/flags.go Outdated Show resolved Hide resolved
op-node/rollup/driver/driver.go Show resolved Hide resolved
op-node/rollup/engine/events.go Show resolved Hide resolved
op-node/rollup/engine/events.go Show resolved Hide resolved
op-node/rollup/interop/interop.go Show resolved Hide resolved
op-node/rollup/interop/interop.go Show resolved Hide resolved
op-node/rollup/interop/interop.go Show resolved Hide resolved
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

op-node/flags/flags.go Show resolved Hide resolved
@protolambda
Copy link
Contributor Author

Unrelated contracts test flakes. Going to rebase, so CI can run against latest develop cleanly.

@protolambda protolambda added this pull request to the merge queue Sep 5, 2024
Merged via the queue into develop with commit ac19f2f Sep 5, 2024
56 checks passed
@protolambda protolambda deleted the interop-cross-safety branch September 5, 2024 23:53
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…m-optimism#11611)

* op-node: experimental interop block verification

* op-node: supervisor RPC init

* op-e2e/actions: test interop safety checks

* op-e2e/op-node: test fixes

* op-node: update comments

* op-node: unit-test interop deriver, trigger cross-safe updates on driver step, to poll for supervisor safety changes

* op-node: add more comments, fix flag description

* op-e2e: fix rebase, add missing argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants