chore(op-service): use errors.New to replace fmt.Errorf with no parameters
#11796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
approved these changes
Sep 12, 2024
|
Seems that some jobs hang without response... |
|
@yukionfire Do you mind rebasing this? It can be merged after rebase |
Okay, I will rebase later |
auto-merge was automatically disabled
September 18, 2024 16:28
Head branch was pushed to by a user without write access
yukionfire
force-pushed
the
chore/errors-fmt
branch
from
80d491a
to
f0ba20b
Compare
yukionfire
force-pushed
the
chore/errors-fmt
branch
from
f0ba20b
to
600b705
Compare
tynes
approved these changes
Sep 18, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 18, 2024
c18ec26
60 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open a new pr for #11176 , since the auto merge queue of old pr is not working correctly and has been closed by bot.
This PR replaces fmt.Errorf without parameters with errors.New
Tests
No new test case need add