Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-node: Remove unused field in ChannelBank #12001

Merged
merged 1 commit into from
Sep 25, 2024
Merged

op-node: Remove unused field in ChannelBank #12001

merged 1 commit into from
Sep 25, 2024

Conversation

palango
Copy link
Contributor

@palango palango commented Sep 19, 2024

Description

Remove an unused field in the ChannelBank

Tests

Adapted tests, field was partially set to nil already.

@palango palango requested review from a team as code owners September 19, 2024 12:14
ajsutton
ajsutton approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks. But seems CI hit some flaky tests and it's run in the celo org so I can't trigger a rerun. Are you able to kick it please?

@palango
Copy link
Contributor Author

palango commented Sep 23, 2024

LGTM thanks. But seems CI hit some flaky tests and it's run in the celo org so I can't trigger a rerun. Are you able to kick it please?

I've re-run the tests and rebased as well, but the contracts-bedrock-tests-heavy-fuzz-modified test keeps timing out. Is there a trick to get that one green?

@ajsutton
Copy link
Contributor

hmm, too long with no output. That suggests it may be trying to do heavy fuzzing of every test instead of just what changed. It's doing a git diff origin/develop...HEAD to find what changed so maybe on your fork try pushing the latest develop to match the ethereum-optimism fork?

cc @smartcontracts who has been working in this area lately. Any ideas here?

auto-merge was automatically disabled September 24, 2024 10:35

Head branch was pushed to by a user without write access

@palango
Copy link
Contributor Author

palango commented Sep 24, 2024

Updating develop in the fork seems to have done the trick.

@ajsutton ajsutton added this pull request to the merge queue Sep 25, 2024
Merged via the queue into ethereum-optimism:develop with commit cbbb45e Sep 25, 2024
58 checks passed
@palango palango deleted the palango/unused-var branch September 25, 2024 08:58
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@palango @samlaf
op-node: Remove unused field in ChannelBank (ethereum-optimism#12001)
a8c962d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palango @ajsutton