Remove AddSingularBatch from ChannelOut interface (prefer AddBlock) #12079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
force-pushed
the
michael/channel-out-remove-add-singular-batch
branch
10 times, most recently
from
13b5ca3
to
064b121
Compare
|
This seems like a sane change, @geoknee do you mind reviewing this when you have some time? |
geoknee
approved these changes
Oct 3, 2024
mdehoog
force-pushed
the
michael/channel-out-remove-add-singular-batch
branch
from
beb5c7d
to
ecee6a0
Compare
|
(rebased on latest |
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 7, 2024
d062c1c
60 checks passed
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
AddSingularBatchfunction from theChannelOutinterface. This was duplicative of theAddBlockmethod.There wasn't a case where
AddSingularBatchwas called without callingBlockToSingularBatchbeforehand (apart from in tests), so this PR is a simplification of the exposed interface. It also lets future ChannelOut implementations access theBlockif needed, as only exposingAddBlockforces callers to always pass a block.Tests
Existing tests have been updated to the newly exposed interface. There were some tests that were specifically testing
AddSingularBatch, so a new test-only interface has been added to expose this as an internal methodaddSingularBatch. Also one of the benchmark tests was updated to callAddBlockrather thanAddSingularBatchwhich required a small helper function to convert from aSinglularBatchto aBlock.Additional context
I'd like to access the block (to check for withdrawal logs in the Bloom) in a
ChannelOutfor L3 batch submission. Exposing the alternateAddSingularBatchwas preventing this.