-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interop: update op-node <> op-supervisor data exchange #12094
Conversation
2e6f977
to
db067d4
Compare
Semgrep found 1 superfluous nil err check before return Ignore this finding from err-nil-check. |
fe20a20
to
18b1bf0
Compare
Semgrep found 12
_args parameter should be wrapped with DeployUtils.encodeConstructor Ignore this finding from sol-deployutils-args. |
2a487bd
to
bb49f11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's lots of overlapping changes from the branch this PR is based on. I am not sure why github hasn't figured that out, but it's a little difficult to see the changes through them.
Lol, as I hit the button the "Refresh" icon appeared, looks like this aspect is resolved. |
bb49f11
to
d8b075a
Compare
Semgrep found 2 require() must include a reason string Ignore this finding from sol-style-require-reason. |
Closing this, it was covered in #12204 |
Description
Work in progress
Tests
Work in progress
Additional context
Metadata
Fix #12077