Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: update op-node <> op-supervisor data exchange #12094

Closed
wants to merge 13 commits into from

Conversation

protolambda
Copy link
Contributor

Description

Work in progress

Tests

Work in progress

Additional context

Metadata

Fix #12077

@protolambda protolambda changed the base branch from develop to interop-recent-safety September 26, 2024 21:55
Copy link
Contributor

semgrep-app bot commented Sep 26, 2024

Semgrep found 1 err-nil-check finding:

superfluous nil err check before return

Ignore this finding from err-nil-check.

Copy link
Contributor

semgrep-app bot commented Sep 27, 2024

Semgrep found 12 sol-deployutils-args findings:

_args parameter should be wrapped with DeployUtils.encodeConstructor

Ignore this finding from sol-deployutils-args.

Copy link
Contributor

@axelKingsley axelKingsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's lots of overlapping changes from the branch this PR is based on. I am not sure why github hasn't figured that out, but it's a little difficult to see the changes through them.

op-node/rollup/engine/events.go Outdated Show resolved Hide resolved
op-node/rollup/interop/interop.go Show resolved Hide resolved
@axelKingsley
Copy link
Contributor

There's lots of overlapping changes from the branch this PR is based on. I am not sure why github hasn't figured that out, but it's a little difficult to see the changes through them.

Lol, as I hit the button the "Refresh" icon appeared, looks like this aspect is resolved.

Copy link
Contributor

semgrep-app bot commented Sep 27, 2024

Semgrep found 2 sol-style-require-reason findings:

require() must include a reason string

Ignore this finding from sol-style-require-reason.

Base automatically changed from interop-recent-safety to develop September 27, 2024 22:21
@protolambda
Copy link
Contributor Author

Closing this, it was covered in #12204

@protolambda protolambda deleted the interop-inputs branch October 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop: op-supervisor local-safe data-ingestion from op-node
2 participants