Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename isthmus to interop on golang files #12133

Conversation

0xDiscotech
Copy link
Contributor

Description

Rename L1BlockIsthmus to L1BlockInterop for consistency with the upgrade naming.
The scope of it is only the Golang files, there will be another one with the changes on the Solidity files because that's how it was asked from reviewers.

Tests

I added no tests, but only modified the contracts name so they don' break

Additional context

PR for the renaming on Soldity files: #12132

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.11%. Comparing base (10a16aa) to head (5904166).
Report is 26 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12133      +/-   ##
===========================================
- Coverage    68.30%   68.11%   -0.20%     
===========================================
  Files           54       54              
  Lines         4118     4118              
===========================================
- Hits          2813     2805       -8     
- Misses        1126     1135       +9     
+ Partials       179      178       -1     
Flag Coverage Δ
cannon-go-tests 68.11% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@protolambda protolambda added this pull request to the merge queue Sep 26, 2024
Merged via the queue into ethereum-optimism:develop with commit 3210a8c Sep 26, 2024
63 checks passed
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants