op-service: Add optional headers to the signer client #12407
Merged
+66
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trianglesphere
force-pushed
the
signer-headers
branch
from
63b2586
to
4c1dbf3
Compare
trianglesphere
force-pushed
the
signer-headers
branch
from
4c1dbf3
to
c3a391a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12407 +/- ##
===========================================
- Coverage 64.32% 64.14% -0.19%
===========================================
Files 52 52
Lines 4348 4348
===========================================
- Hits 2797 2789 -8
- Misses 1376 1385 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
tynes
reviewed
Oct 10, 2024
tynes
approved these changes
Oct 11, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 11, 2024
1222534
58 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…ism#12407) * op-service: Add optional headers to the signer client * Explain flag usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new flag to the signer client
HEADERSwhich will provide a set of headers to pass to the remote signer.This also modifies the TLSConfig to better handle enabling TLS. Previously
TLSConfig.TLSEnabled()would alway return true because it would default every value duringReadCLIConfig. NowTLSConfig.TLSEnabled()only returns true if any of the flags are set.Tests
Unit tests for flag parsing.