op-deployer: Most implementation addresses not set in state.json when standard release tag used #12434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mds1
reviewed
Oct 16, 2024
mds1
reviewed
Oct 16, 2024
mds1
reviewed
Oct 16, 2024
mds1
reviewed
Oct 16, 2024
mds1
reviewed
Oct 16, 2024
mds1
reviewed
Oct 16, 2024
There was a problem hiding this comment.
In general LGTM! Main comment is that we should add a test for this fix. Would like either @mslipper or @bitwiseguy to review before merging, so intentionally did not approve
blmalone
force-pushed
the
10-11-op-deployer_most_implementation_addresses_not_set_in_state.json_when_standard_release_tag_used
branch
from
d0f7258
to
b543da6
Compare
mslipper
requested changes
Oct 16, 2024
… standard release tag used
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
blmalone
force-pushed
the
10-11-op-deployer_most_implementation_addresses_not_set_in_state.json_when_standard_release_tag_used
branch
from
477970c
to
90e9b58
Compare
mslipper
approved these changes
Oct 16, 2024
mslipper
deleted the
10-11-op-deployer_most_implementation_addresses_not_set_in_state.json_when_standard_release_tag_used
branch
mds1
reviewed
Oct 17, 2024
Comment on lines
+97
to
+98
| currentBlock, _ := env.L1Client.BlockNumber(ctx) | ||
| block, _ := env.L1Client.BlockByNumber(ctx, big.NewInt(int64(currentBlock))) |
There was a problem hiding this comment.
Do we need to check the error returned from these two calls, or is there a reason it's safe to ignore them here?
There was a problem hiding this comment.
Good spot, I'll make a follow up pr to fix this.
There was a problem hiding this comment.
We should create some semgrep rules to catch these - I will look into that.
mds1
reviewed
Oct 17, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
… standard release tag used (ethereum-optimism#12434) * op-deployer: Most implementation addresses not set in state.json when standard release tag used * Update op-chain-ops/deployer/pipeline/opchain.go Co-authored-by: Matt Solomon <matt@mattsolomon.dev> * fix: parallel execution of commands. * fix: tests added * fix: vscode revert * use channel approach --------- Co-authored-by: Matt Solomon <matt@mattsolomon.dev> Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users run
op-deployer, it's likely that they're going to be using a standard release version e.g.op-contracts/v*. This means that most executions ofop-deployerwill only be executingDeployOPChain.s.solunder the hood. WhenDeployOPChain.s.solis executed, theimplementationsDeploymentproperty instate.jsonisn't set properly. This is because these addresses normally only get set inDeployImplementations.s.sol, which is skipped in this case. This PR adds these addresses tostate.jsonwhen only theDeployOPChain.s.solpipeline is executed.Note: there is a TODO left in the code:
This will be left for a later PR.
Related issue: https://github.com/ethereum-optimism/platforms-team/issues/347