feat(conductor): Implement OverrideLeader & LeaderOverriden method for conductor #12451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x00101010
force-pushed
the
rpc/leader-override
branch
from
2c048d1
to
d236ff7
Compare
zhwrd
approved these changes
Oct 16, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 16, 2024
ef009e3
58 checks passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12451 +/- ##
===========================================
- Coverage 64.60% 64.42% -0.19%
===========================================
Files 52 52
Lines 4371 4371
===========================================
- Hits 2824 2816 -8
- Misses 1372 1381 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make leadership override more explicit, add LeaderOverriden method to check if leader is indeed overridden.
Tests
in op-e2e tests
Additional context
Metadata