Holocene: e2e test for Holocene's configurable eip-1559 params #12499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
1ce8447
to
88bcf36
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
from
b9cedb3
to
38ca88a
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
88bcf36
to
109410a
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
2 times, most recently
from
30886ac
to
c8fbf7f
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
109410a
to
ffa6ccd
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
4 times, most recently
from
7af5be9
to
57ee64a
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
4 times, most recently
from
f9c302f
to
81935eb
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
from
57ee64a
to
958990b
Compare
|
Semgrep found 4
Prefer |
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
from
958990b
to
f00d46e
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
2 times, most recently
from
3b08777
to
a1c2546
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
from
f00d46e
to
3eec48e
Compare
tynes
force-pushed
the
holocene-sysconfig
branch
from
a1c2546
to
eb6461c
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
from
3eec48e
to
005949c
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
from
005949c
to
eacb5ac
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
2 times, most recently
from
fb37d9e
to
1095bc5
Compare
roberto-bayardo
force-pushed
the
holocene-1559-e2e
branch
from
1095bc5
to
2ad0ff0
Compare
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides an E2E test that exercises the updating of the EIP-1559 parameters through SystemConfig contract, ensuring the base fee gets computed as expected both before and after the update.