feat(ci): add tests for semgrep rules #12563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Oct 22, 2024
mds1
reviewed
Oct 22, 2024
smartcontracts
force-pushed
the
sc/ci-semgrep-rules-tests
branch
from
6c37d20
to
8e2c8e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12563 +/- ##
===========================================
- Coverage 65.04% 64.86% -0.18%
===========================================
Files 54 54
Lines 4460 4460
===========================================
- Hits 2901 2893 -8
- Misses 1382 1391 +9
+ Partials 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurelian
reviewed
Oct 22, 2024
smartcontracts
force-pushed
the
sc/ci-semgrep-rules-tests
branch
from
8e2c8e3
to
8c4d430
Compare
Adds rule tests for all semgrep rules and fixes a few bugs that were found during testing. Moves semgrep rules into the semgrep folder without the . prefix because the prefix caused semgrep to be unable to run the tests.
smartcontracts
force-pushed
the
sc/ci-semgrep-rules-tests
branch
from
8c4d430
to
d0eac5a
Compare
mds1
approved these changes
Oct 22, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Adds rule tests for all semgrep rules and fixes a few bugs that were found during testing. Moves semgrep rules into the semgrep folder without the . prefix because the prefix caused semgrep to be unable to run the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rule tests for all semgrep rules and fixes a few bugs that were found during testing. Moves semgrep rules into the semgrep folder without the . prefix because the prefix caused semgrep to be unable to run the tests.