Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: Handle first L1 Parent Ref in CandidateCrossSafe #12830

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

axelKingsley
Copy link
Contributor

Extends: https://github.com/ethereum-optimism/optimism/pull/12818/files

The prior commit made it so that getting PreviousDerivedFrom would fail when there wasn't data behind the query. This should solve instances where the code attempts to attach 0-value parents to the L1 in WithParent.

However! The CanddiateCrossSafe function will manually use a zero-value ID to build parents into the L1 when the database is empty. This totally side-steps the returned error in the prior PR.

Infrastructure on L1 is failing with this line called out:

goroutine 140 [running]:
github.com/ethereum-optimism/optimism/op-supervisor/supervisor/types.BlockSeal.WithParent({{0x4d, 0x0, 0xfd, 0x89, 0x12, 0x1d, 0x13, 0xac, 0xff, 0x9a, ...}, ...}, ...)
    /app/op-supervisor/supervisor/types/types.go:247 +0x12e
github.com/ethereum-optimism/optimism/op-supervisor/supervisor/backend/db.(*ChainsDB).CandidateCrossSafe(0xc000320c60, {0xaf1139, 0x0, 0x0, 0x0})
    /app/op-supervisor/supervisor/backend/db/query.go:242 +0x459
github.com/ethereum-optimism/optimism/op-supervisor/supervisor/backend/cr

@axelKingsley axelKingsley changed the title Handle first L1 Parent Ref in CandidateCrossSafe interop: Handle first L1 Parent Ref in CandidateCrossSafe Nov 5, 2024
Copy link
Contributor

@jelias2 jelias2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Axel explained the logs from the panic and how it affects, lgtm

@axelKingsley axelKingsley added this pull request to the merge queue Nov 5, 2024
Merged via the queue into develop with commit 39e6e6f Nov 5, 2024
49 checks passed
@axelKingsley axelKingsley deleted the interop-fix-L1Parent-CandidateCrossSafe branch November 5, 2024 20:24
GrapeBaBa pushed a commit to optimism-java/optimism that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants