Lower SafetyChecker gas to below 1.5 million #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout requires, all pass
geohot
changed the title
|
Yea, it seems like the ExternStateToken.json thing isn't a bug, the contract actually contains "JUMPDEST 0xD2". I don't think the compiler change could have caused this, there's probably just randomness or something. (note that you can comment out all the speed stuff and the contract still works) |
|
Tests fixed! |
|
closing in favor of #218 |
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
This enables tracking code coverage across packages to see an increase in code coverage due to the e2e test.
Merged
This was referenced Apr 27, 2024
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on "kall" compiler change.
Note that opcodeWhitelist is now hardcoded, this needs to be updated.
ExternStateToken.json is also failing, looking into why.