ovm-toolchain: check waffle provider defined #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* Another stab at a good hardhat-deploy * Testing etherscan verifications * Fix linting * remove artifacts * keep old deploy script * remove old hardhat-typechain dependency * remove unused import * remove kovan config * Tweak deployment a bit * Clean up defaults * rename hardhat => hh * Use mock bond manager * Make deploy a bit more robust * I committed my private key again. There goes my goerli eth * and my infura api key too * Fix lint errors * Use strict ordering * refactor: use helper for easy AddressManager deployments (#350) * Clean up georgios pr * use dotenv to manage deployer keys * Update src/hardhat-deploy-ethers.ts Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Stricter checking on address set * add argument for sequencer address * minor tweaks to console.log comments * move predeploy addresses into their own file * add small comment for clarity * update deploy script * fix incorrect env var in deploy script * adding deploy.js shim to get ci to work * simplify deployment environment vars * temporary tweaks to get a ci run to pass * print out deploy artifacts * fix artifact log output format * fix contract names in artifact log output * add eth gateway to deploy * add OVM_Proposer to address manager * add some comments for clarity * remove bytecode hash from compiler settings * minor tweaks in response to review * transfer address manager ownership after deploy * explicitly attach deployer to address manager Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
Adds a sequencer mode that runs ahead of the verifier. Also changes the block timestamps + implements epochs correctly in the batch submission. Does not reconcile sequenced blocks with verified blocks (but does check at least one block for consistency between a full verifier and full sequencer in the e2e test) It is possible for the sequencer to get behind the L1 chain tip and it does not handle re-orgs well.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This small PR adds a check in our
waffleV2export that_web3Provideris defined, as some dev environments with stricttsconfigs previously rejected builds because the dependencyinvokes an object which is potentially undefined.Contributing Agreement