-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump ethers, remove old oz deps #3444
Conversation
|
Bumps ethers to the latest version and removes unused openzeppelin deps that were in the root of the project. There was no need to have those older versions of openzeppelin around, I do not believe they were being used at all but we should be sure that the exact version of openzeppelin is compiled into the contracts.
e1ab41c
to
1cf0b29
Compare
New versions of ethers break smock, cc @smartcontracts |
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
@@ -115,6 +115,6 @@ | |||
"typescript": "^4.6.2" | |||
}, | |||
"peerDependencies": { | |||
"ethers": "^5" | |||
"ethers": "^5.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be ^5
Need to update smock to 2.3.0 everywhere, will fix this |
@smartcontracts will take over this PR |
Replaced by #3500 |
Description
Bumps ethers to the latest version and removes unused openzeppelin deps that were in the root of the project. There was no need to have those older versions of openzeppelin around, I do not believe they were being used at all but we should be sure that the exact version of openzeppelin is compiled into the contracts.
Closes #3372