Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump ethers, remove old oz deps #3444

Closed
wants to merge 1 commit into from
Closed

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Sep 13, 2022

Description

Bumps ethers to the latest version and removes unused openzeppelin deps that were in the root of the project. There was no need to have those older versions of openzeppelin around, I do not believe they were being used at all but we should be sure that the exact version of openzeppelin is compiled into the contracts.

Closes #3372

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

⚠️ No Changeset found

Latest commit: 1cf0b29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Bumps ethers to the latest version and removes unused openzeppelin
deps that were in the root of the project. There was no need to have
those older versions of openzeppelin around, I do not believe they
were being used at all but we should be sure that the exact version
of openzeppelin is compiled into the contracts.
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-op-bindings Area: op-bindings A-pkg-core-utils Area: packages/core-utils A-integration Area: integration tests A-pkg-sdk Area: packages/sdk labels Sep 13, 2022
@tynes
Copy link
Contributor Author

tynes commented Sep 14, 2022

New versions of ethers break smock, cc @smartcontracts

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 14, 2022
@@ -115,6 +115,6 @@
"typescript": "^4.6.2"
},
"peerDependencies": {
"ethers": "^5"
"ethers": "^5.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be ^5

@smartcontracts
Copy link
Contributor

New versions of ethers break smock, cc @smartcontracts

Need to update smock to 2.3.0 everywhere, will fix this

@tynes
Copy link
Contributor Author

tynes commented Sep 15, 2022

@smartcontracts will take over this PR

@tynes
Copy link
Contributor Author

tynes commented Sep 19, 2022

Replaced by #3500

@tynes tynes closed this Sep 19, 2022
@tynes tynes deleted the deps/bump-ethers branch September 19, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-integration Area: integration tests A-op-bindings Area: op-bindings A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-core-utils Area: packages/core-utils A-pkg-sdk Area: packages/sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo after abi formatting using interface.format function
2 participants