-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-program: Introduce basic infrastructure for fault proof program #5297
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5297 +/- ##
===========================================
+ Coverage 39.90% 40.34% +0.44%
===========================================
Files 382 385 +3
Lines 24376 24464 +88
Branches 838 838
===========================================
+ Hits 9727 9871 +144
+ Misses 13916 13853 -63
- Partials 733 740 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice project setup! op-program
is good for now, we can rename it later if desired. op-node
is still op-node though, that name stuck 😅
Just a nit about license year + reviewers configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. CI just looks flaky right now
@ajsutton needs a rebase to fix CI |
Executable is capable of printing its version and configuring logging. 🎉
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Sets up the basic infrastructure for the fault proof program.
Tests
Modified the pattern we use for program init a bit so that we can write unit tests for CLI args. It introduces a little more complexity in the
main.go
file, but in return we can actually test the CLI args and there's a clear programmatic API to start the program given just a log and config instance.Invariants
For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.
Fixes https://linear.app/optimism/issue/CLI-3738/fault-proof-program-infrastructure